Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): rewrite "show more" facet tests in playwright #4465

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

alexprudhomme
Copy link
Contributor

https://coveord.atlassian.net/browse/KIT-3578

This should fix the facet.2.cypress test getting stuck indefinitely.

@alexprudhomme alexprudhomme enabled auto-merge (squash) September 25, 2024 20:19
Copy link

github-actions bot commented Sep 25, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.3 236.3 0
commerce 339.1 339.1 0
search 411.4 411.4 0
insight 397.6 397.6 0
recommendation 248.5 248.5 0
ssr 405.4 405.4 0
ssr-commerce 351.4 351.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme marked this pull request as draft September 26, 2024 18:29
auto-merge was automatically disabled September 26, 2024 18:29

Pull request was converted to draft

@alexprudhomme alexprudhomme marked this pull request as ready for review September 27, 2024 14:00
@alexprudhomme alexprudhomme merged commit 025804a into master Sep 30, 2024
112 checks passed
@alexprudhomme alexprudhomme deleted the test/KIT-3578 branch September 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants